Skip to content

Mark non-test classes with __test__ = False attribute #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mateusz834
Copy link

This resolves few warnings that were emitted by pytest.

See: https://docs.pytest.org/en/stable/example/pythoncollection.html#customizing-test-collection

This resolves few warnings that were emitted by pytest.
@mateusz834 mateusz834 marked this pull request as ready for review August 18, 2025 08:40
Copy link

@cecyliaborek cecyliaborek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
just wondering, any reason why you chose to use __test__ = False instead of renaming those non-test classes? e.g. SearchCommandFixture instead of TestSearchCommand. That could be a better self-documentation of the code

Comment on lines 103 to +105
class TestStreamingCommand(StreamingCommand):
__test__ = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is not being referenced anywhere, wondering if we could remove it (could always bring it back from the version control if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants