Skip to content

Fix role name case sensitivity causing state mismatch on Splunk Cloud #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raman1236 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix role name case sensitivity causing state mismatch on Splunk Cloud #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions splunk/resource_splunk_authorization_roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ import (
"encoding/json"
"errors"
"fmt"
"github.com/splunk/terraform-provider-splunk/client/models"
"net/http"
"regexp"
"strings"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/splunk/terraform-provider-splunk/client/models"
)

func authorizationRoles() *schema.Resource {
Expand All @@ -19,6 +20,9 @@ func authorizationRoles() *schema.Resource {
Required: true,
ForceNew: true,
Description: "Required. The name of the user role to create.",
StateFunc: func(val interface{}) string {
return strings.ToLower(val.(string))
},
},
"capabilities": {
Type: schema.TypeSet,
Expand Down Expand Up @@ -154,7 +158,8 @@ func authorizationRolesCreate(d *schema.ResourceData, meta interface{}) error {
return err
}

d.SetId(name)
// Splunk server lowercases role names, so we store the lowercased version
d.SetId(strings.ToLower(name))
return authorizationRolesRead(d, meta)
}

Expand Down Expand Up @@ -321,7 +326,7 @@ func getAuthorizationRolesByName(name string, httpResponse *http.Response) (Auth
_ = json.NewDecoder(httpResponse.Body).Decode(&response)
re := regexp.MustCompile(`(.*)`)
for _, entry := range response.Entry {
if name == re.FindStringSubmatch(entry.Name)[1] {
if strings.EqualFold(name, re.FindStringSubmatch(entry.Name)[1]) {
return &entry, nil
}
}
Expand Down