Fix HEC useACK unmarshal error on Splunk Cloud 8.2+#231
Open
raman1236 wants to merge 1 commit into
Open
Conversation
Splunk Cloud 8.2+ returns "true"/"false" as string values for the
useACK field in HTTP Event Collector responses, instead of "0"/"1".
The previous json:",string" struct tag expected a numeric string and
failed with: json: invalid use of ,string struct tag, trying to unmarshal
"true" into int
Fix: Replace the int type with a custom IntBool type that implements
json.Unmarshaler to handle both numeric ("0"/"1") and boolean
("true"/"false") string representations.
Fixes splunk#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #130
On Splunk Cloud 8.2+ (Victoria Experience), the HTTP Event Collector API returns
"true"/"false"as string values for theuseACKfield, instead of the numeric"0"/"1"returned by earlier versions. This causes the JSON decoder to fail with:Changes
IntBooltype inclient/models/http_event_collector.gothat implementsjson.Unmarshaler"0"/"1") and boolean strings ("true"/"false")HttpEventCollectorObject.UseACKfield frominttoIntBoolIntBooltointwhen interacting with the Terraform schemaImpact
This is a backward-compatible fix. The
use_ackattribute in the Terraform schema remainsTypeInt(0 or 1). The custom type transparently handles both response formats from different Splunk versions.