Skip to content

Empty string issue #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zscholl wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Empty string issue #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45e8e5
failing test
zscholl Nov 16, 2020
905cdd0
remove omitempty
zscholl Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/models/saved_searches.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type SavedSearchObject struct {
ActionEmailSendCSV int `json:"action.email.sendcsv,string,omitempty" url:"action.email.sendcsv,omitempty"`
ActionEmailSendPDF bool `json:"action.email.sendpdf" url:"action.email.sendpdf"`
ActionEmailSendResults bool `json:"action.email.sendresults" url:"action.email.sendresults"`
ActionEmailSubject string `json:"action.email.subject,omitempty" url:"action.email.subject,omitempty"`
ActionEmailSubject string `json:"action.email.subject,omitempty" url:"action.email.subject"`
ActionEmailTo string `json:"action.email.to,omitempty" url:"action.email.to,omitempty"`
ActionEmailTrackAlert bool `json:"action.email.track_alert" url:"action.email.track_alert"`
ActionEmailTTL string `json:"action.email.ttl,omitempty" url:"action.email.ttl,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions splunk/resource_splunk_saved_searches_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ resource "splunk_saved_searches" "test" {
action_email_max_results = 100
action_email_send_csv = 1
action_email_send_results = false
action_email_subject = "Splunk Alert: $name$"
action_email_subject = ""
action_email_to = "splunk@splunk.com"
action_email_track_alert = true
dispatch_earliest_time = "rt-15m"
Expand Down Expand Up @@ -219,7 +219,7 @@ func TestAccSplunkSavedSearches(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "action_email_max_results", "100"),
resource.TestCheckResourceAttr(resourceName, "action_email_send_csv", "1"),
resource.TestCheckResourceAttr(resourceName, "action_email_send_results", "false"),
resource.TestCheckResourceAttr(resourceName, "action_email_subject", "Splunk Alert: $name$"),
resource.TestCheckResourceAttr(resourceName, "action_email_subject", ""),
resource.TestCheckResourceAttr(resourceName, "action_email_to", "splunk@splunk.com"),
resource.TestCheckResourceAttr(resourceName, "action_email_track_alert", "true"),
resource.TestCheckResourceAttr(resourceName, "dispatch_earliest_time", "rt-15m"),
Expand Down