feat(js): flush assigned when reaching limit #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-karlsson
force-pushed
the
adaptive-flush
branch
from
d796d10 to
7c85136
Compare
andreas-karlsson
changed the title
nicklasl
force-pushed
the
adaptive-flush
branch
from
7c85136 to
a6d9bab
Compare
nicklasl
reviewed
Nov 20, 2025
| } | ||
|
|
||
| private async flushAssigned(): Promise<void> { | ||
| const writeFlagLogRequest = this.resolver.flushAssigned(); |
Member
There was a problem hiding this comment.
flushAssigned() will only return a request if the logs buffer in WASM is >= 3.9 MB.
nicklasl
reviewed
Nov 20, 2025
| private async flushAssigned(): Promise<void> { | ||
| const writeFlagLogRequest = this.resolver.flushAssigned(); | ||
| if (writeFlagLogRequest.length > 0) { | ||
| await this.sendFlagLogs(writeFlagLogRequest); |
nicklasl
force-pushed
the
adaptive-flush
branch
from
df55ac0 to
66e5ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.