Skip to content

Conversation

@nicklasl
Copy link
Member

@nicklasl nicklasl commented Nov 24, 2025

Summary

Refactors Java provider shutdown lifecycle to properly manage resources:

  • Factories don't manage shutdown: ChannelFactory and new HttpClientFactory create resources but delegates shutdown to callers
  • Improved shutdown sequence: Provider now properly terminates executors, channels, and HTTP clients with timeouts
  • Sync log writes on shutdown: Adds writeSync() to flush logs before termination
  • Comprehensive tests: New integration tests and gRPC flag logger tests with in-process server

Fixes resource leaks and ensures clean shutdown.

@nicklasl nicklasl force-pushed the java/shutdown branch 6 times, most recently from 74ec958 to 8328a85 Compare November 28, 2025 14:37
@nicklasl nicklasl marked this pull request as ready for review December 2, 2025 08:12
@nicklasl nicklasl merged commit 17dfa47 into main Dec 4, 2025
10 checks passed
@nicklasl nicklasl deleted the java/shutdown branch December 4, 2025 14:57
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants