feat(go): Materialization fallback #168
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
go-sticky-fallback
branch
from
3997627 to
0b833ca
Compare
fabriziodemaria
force-pushed
the
go-sticky-fallback
branch
from
2ddf5ab to
236844a
Compare
nicklasl
reviewed
Nov 25, 2025
Address review feedback by moving the sticky resolve response handling logic from SwapWasmResolverApi to LocalResolverProvider. Changes: - Update WasmResolverApi.ResolveWithSticky to return ResolveWithStickyResponse instead of ResolveFlagsResponse - Move response handling logic (Success/MissingMaterializations) from SwapWasmResolverApi to LocalResolverProvider - Add handleStickyResponse, storeUpdates, and handleMissingMaterializations methods to LocalResolverProvider - Remove sticky strategy parameter from NewSwapWasmResolverApi - Update all tests to work with the new interface - Remove obsolete sticky_resolve_strategy_test.go (logic now tested at provider level) This separates concerns: SwapWasmResolverApi is now only responsible for managing WASM instances, while LocalResolverProvider handles the business logic for sticky resolve strategies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
fabriziodemaria
force-pushed
the
go-sticky-fallback
branch
from
236844a to
171f8c8
Compare
nicklasl
reviewed
Nov 26, 2025
Comment on lines
+23
to
+24
| APIClientID string | ||
| APIClientSecret string |
Member
There was a problem hiding this comment.
merge conflict?, we don't want to re-add these
nicklasl
reviewed
Nov 26, 2025
| wg sync.WaitGroup | ||
| mu sync.Mutex | ||
| pollInterval time.Duration | ||
| stickyResolveStrategy StickyResolveStrategy |
Member
There was a problem hiding this comment.
The current WIP suggestion on how we can/should have this:
- param to the resolver named is materializationStore
- the type of materializationStore is
MaterializationReader(interface).- there are functions there to read from a store to support custom targeting.
- There is also a
MaterializationWriterwith write functions. - If the user provides no
materializationStorewe fall back to remote resolve. - If the user provides an object that only implement
MaterializationReaderthe provider will support custom targeting. - If the user provides an object that implements both
MaterializationReaderandMaterializationWriterit supports sticky assignment as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.