Skip to content

Use bootstrap from CDN #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathan3d merged 4 commits into from
Jan 8, 2025
Merged

Use bootstrap from CDN #179

nathan3d merged 4 commits into from
Jan 8, 2025

Conversation

@5peak2me
Copy link
Contributor

@5peak2me 5peak2me commented Jan 8, 2025

What has changed

Remove static require

// use cdn files
require("bootstrap/dist/css/bootstrap.css")
require("bootstrap/dist/js/bootstrap.bundle.js")

Why was it changed

WX20250108-095829
WX20250108-095448

Related issues

@5peak2me 5peak2me force-pushed the main branch 3 times, most recently from c51083a to 5922a1c Compare January 8, 2025 03:19
@5peak2me
Copy link
Contributor Author

5peak2me commented Jan 8, 2025

Unfortunately, it seems that ruler-frontend-tests fails in unit test, and fails locally for me.

@5peak2me 5peak2me mentioned this pull request Jan 8, 2025
Open
@nathan3d nathan3d merged commit 8d2a943 into spotify:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathan3d nathan3d nathan3d approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@5peak2me @nathan3d