Skip to content

Conversation

@5peak2me
Copy link
Contributor

@5peak2me 5peak2me commented Jan 8, 2025

What has changed

Snipaste_2025-01-08_20-07-00

  • Configuration cache feature supported
  • Extract the file method to the FileProvider.kt

Why was it changed

Configuration cache is not currently supported for the following reasons:

  • use project in executing time.
override fun provideDependencies(): Map<String, List<DependencyComponent>> {
       val dependencyParser = EntryParser()
       val entries = dependencyParser.parse(project, rulerConfig().appInfo)

       val classNameSanitizer = ClassNameSanitizer(provideMappingFile())
       val dependencySanitizer = DependencySanitizer(classNameSanitizer)
       return dependencySanitizer.sanitize(entries)
}

override fun print(content: String) = project.logger.lifecycle(content)
  • exec operations in executing time
private fun createApkFile(): Map<String, List<File>> {
        val android = project.extensions.findByName("android") as BaseExtension?
        val apkCreator = ApkCreator(android?.sdkDirectory)

        val apkFile = bundleFile.asFile.get()
        return if (apkFile.extension == "apk") {
            mapOf(ApkCreator.BASE_FEATURE_NAME to listOf(apkFile))
        } else {
            apkCreator.createSplitApks(
                apkFile,
                deviceSpec.get(),
                workingDir.asFile.get()
            )
        }
    }

Related issues

#140

@5peak2me 5peak2me closed this Jan 19, 2025
@5peak2me 5peak2me force-pushed the configuration-cache branch from 3ee722b to aac7d8e Compare January 19, 2025 13:17
@nathan3d
Copy link
Collaborator

If you can get tests passing I don't mind merging

@5peak2me
Copy link
Contributor Author

Thanks @nathan3d, I'm working around the current limitations and will resubmit the PR later.

@5peak2me 5peak2me reopened this Jan 24, 2025
@5peak2me 5peak2me force-pushed the configuration-cache branch 5 times, most recently from 74165e7 to b06004b Compare January 24, 2025 12:30
@5peak2me 5peak2me force-pushed the configuration-cache branch from b06004b to ba43aa3 Compare January 24, 2025 12:48
@5peak2me 5peak2me force-pushed the configuration-cache branch from 1d78b6e to e246939 Compare January 24, 2025 13:26
@nathan3d nathan3d merged commit a60ba28 into spotify:main Jan 27, 2025
4 checks passed
@5peak2me 5peak2me deleted the configuration-cache branch April 19, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants