[Contribute] fix: preserve parallel tool call order by index (#291) - #296
Open
love9rose wants to merge 1 commit into
Open
[Contribute] fix: preserve parallel tool call order by index (#291)#296love9rose wants to merge 1 commit into
love9rose wants to merge 1 commit into
Conversation
…aba#291) DashScope returns parallel tool calls each carrying an explicit `index`. In buildGeneration we now sort the tool calls by their `index` before mapping them to AssistantMessage.ToolCall, so interleaved stream chunks are aggregated into the correct positions downstream. Single tool calls are unaffected (sorting is a no-op). The sorting logic is extracted into a package-private static helper sortToolCallsByIndex(...) so it is unit-testable without the tool-execution path. Added test testParallelToolCallIndexOrderPreserved feeds two tool calls in reversed index order and asserts they come back ordered by index.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA baizhan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DashScope returns parallel tool calls each carrying an explicit index. Previously �uildGeneration mapped them to AssistantMessage.ToolCall without preserving that order, so when parallel tool calls arrive as interleaved stream chunks they could be aggregated into the wrong positions downstream.
Fix
Test
Verification
mvn -pl models/dashscope test -Dtest=DashScopeChatModelTests#testParallelToolCallIndexOrderPreserved -> BUILD SUCCESS.
Related issue: #291