This repository was archived by the owner on May 14, 2025. It is now read-only.
Add InfluxDB/Grafana charts for Task-run duration #3304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- augment the docker-compose-influx to enable task.management.metrics.xxx for influx. - add initial scdf-task-batch grafana dashboard to springcloud/spring-cloud-dataflow-grafana-influxdb image. - update prometheus, myslq, grafana and influx image versions. Depends on spring-cloud/spring-cloud-task/pull/612 Depends on spring-attic/spring-cloud-task-app-starters-core/issues/14 Resolves spring-attic#3295
sabbyanandan
reviewed
Jul 3, 2019
| @@ -35,6 +35,8 @@ services: | |||
| dataflow-server: | |||
| image: springcloud/spring-cloud-dataflow-server:${DATAFLOW_VERSION:?DATAFLOW_VERSION is not set!} | |||
| container_name: dataflow-server | |||
| volumes: | |||
| - '/tmp/apps:/apps/' | |||
There was a problem hiding this comment.
Any specific reasons why we need this volume mount? I don't see it being used in the associated changes in this PR, though.
There was a problem hiding this comment.
Nice catch! I will remove it.
I used this volume to register and test the locally build metrics enabled Task apps.
- this volume was used for testing with locally build apps
|
Merged in ca67cc5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on spring-cloud/spring-cloud-task/pull/612
Depends on spring-attic/spring-cloud-task-app-starters-core/issues/14
Resolves #3295