Log chat client completion data and make the response text available in the Observation Context #4417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ThomasVitale |
...c/main/java/org/springframework/ai/chat/client/observation/ChatClientObservationContext.java
Outdated
Show resolved
Hide resolved
…in the Observation Context
jonatan-ivanov
force-pushed
the
chat-client-log-completion
branch
from
f04c0c7 to
09bbafc
Compare
ThomasVitale
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main driver of this change to make the response test available in the Chat Client Observation Context in
call()andstream()scenarios.This also introduces chat client log completion which was missing before mainly because the response text was not available in the
stream()use-case.