Support generic output schemas in async MCP tool providers - #6791
Open
wxggzz wants to merge 1 commit into
Open
Conversation
Signed-off-by: wxggzz <weixiegen0506@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate MCP output schemas for parameterized reactive return types in both stateful and stateless async tool providers.
When an
@McpTool(generateOutputSchema = true)method returns a type such asMono<List<Result>>, the reactive payload is aParameterizedType. Both async providers converted non-Class<?>payloads tonullbefore callingClassUtils, causing tool registration to fail withIllegalArgumentException: Class must not be null.This change:
ParameterizedTypepayloads;This supersedes and extends #5920 by covering both async provider variants and adding end-to-end structured-content assertions.
Testing
./mvnw -Dmaven.build.cache.enabled=false -pl mcp/mcp-annotations -am test(1,378 tests, 0 failures, 2 skipped)./mvnw clean package(169 reactor modules, BUILD SUCCESS)