Preserve $schema in Typed Elicitation Requests - #6793
Open
TwistedRiCen wants to merge 1 commit into
Open
Conversation
Keep generated JSON Schema metadata when typed sync and async request contexts create elicitation requests. Fixes spring-projects#6730 Signed-off-by: liangdacheng <liangdacheng@gitlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typed MCP elicitation requests remove generated
$schemametadata beforesending the request. MCP 2025-11-25 and later support
$schemainrequestedSchema.Preserve the generated metadata for both sync and async typed elicitation
requests.
Testing
DefaultMcpAsyncRequestContextTestsDefaultMcpSyncRequestContextTestsmcp-annotationstest suiteFull repository builds were also attempted on Windows, but both this branch
and untouched
upstream/mainencounter CRLF-sensitive observation testfailures outside
mcp-annotations. The Spring AI PR build runs on Ubuntu.Fixes #6730