Skip to content

Add aggregation temporality to OtlpProperties #34958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonatan-ivanov
Copy link
Member

In Micrometer 1.11.0-RC1, a new property was introduced in OtlpConfig to define aggregation temporality.
See micrometer-metrics/micrometer#3625

@jonatan-ivanov jonatan-ivanov added type: enhancement A general enhancement theme: observability Issues related to observability labels Apr 12, 2023
@jonatan-ivanov jonatan-ivanov added this to the 3.1.0-RC1 milestone Apr 12, 2023
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible OtlpPropertiesTests.defaultValuesAreConsistent() should also be updated to check that the default for the new property is aligned with Micrometer.

@jonatan-ivanov jonatan-ivanov force-pushed the otlp-aggregation-temporality branch from d71a6fb to cde9011 Compare April 13, 2023 17:08
In Micrometer 1.11.0-RC1, a new property was introduced in OtlpConfig
to define aggregation temporality.
See micrometer-metrics/micrometer#3625
@jonatan-ivanov jonatan-ivanov force-pushed the otlp-aggregation-temporality branch from cde9011 to 9774d8a Compare April 13, 2023 17:10
@jonatan-ivanov jonatan-ivanov merged commit 5d49889 into spring-projects:main Apr 13, 2023
@jonatan-ivanov jonatan-ivanov deleted the otlp-aggregation-temporality branch April 13, 2023 19:27
@jonatan-ivanov jonatan-ivanov self-assigned this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants