Skip to content

Conversation

maziyarbahramian
Copy link

@maziyarbahramian maziyarbahramian commented Aug 29, 2025

ScheduledTasksObservabilityAutoConfiguration Renamed to ScheduledTasksObservationAutoConfiguration to align naming

Related to #46993

Notes

This is my first contribution to Spring Boot (and to open source in general).
If I missed any conventions or best practices, please let me know. I’ll be happy to adjust. 🙏

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2025
@maziyarbahramian maziyarbahramian force-pushed the gh-46993 branch 2 times, most recently from 9a7daf1 to 268d349 Compare August 29, 2025 13:16
@nosan
Copy link
Contributor

nosan commented Aug 29, 2025

Hi @maziyarbahramian, and congrats on your first pull request!

I've checked your changes, and they look good to me, but there is a compile error. Can you fix it, please?

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':module:spring-boot-micrometer-observation:compileTestJava'.
> Compilation failed; see the compiler output below.
  /Users/Dmytro.Nosan/IdeaProjects/spring-boot/module/spring-boot-micrometer-observation/src/test/java/org/springframework/boot/micrometer/observation/autoconfigure/ScheduledTasksObservationAutoConfigurationTests.java:50: error: illegal '.'
                assertThat(registrar.getObservationRegistry())..isEqualTo(observationRegistry);

You can verify the changes locally by running
./gradlew :module:spring-boot-micrometer-observation:build or ./gradlew build.

Also, I highly recommend to read the contribution guidelines as it has lots of useful information.

Thanks!

…sObservationAutoConfiguration to align naming

Signed-off-by: Maziyar Bahramian <[email protected]>
@maziyarbahramian
Copy link
Author

Hi @Dmytro.Nosan,

Thanks for reviewing! I've fixed the typo in ScheduledTasksObservationAutoConfigurationTests — the extra . in the assertion has been removed.
All changes have been applied, and the branch is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants