Move blocking random key generation to executor thread #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Arooba-git
force-pushed
the
fix-blocking-call
branch
from
fb2f40f to
9f2261a
Compare
|
bump |
king-2929
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the effort for this handy project!
This is a minor fix pertaining to a blocking call in
KeyCommandsTestsclass as detected by BlockHound:Of course the method is just used in the test cases but since this is the official examples repository, I think the fix could set a good example for how we should try to avoid blocking calls in reactive apps wherever possible, to keep the pipeline reactive end to end. :)
We re-ran the test cases and also evaluated the performance (in terms of latency) before and after the fix
Parking duration of main thread before fix
After
