Skip to content

Conversation

this-amine
Copy link
Contributor

Expose _id field in BucketOperation and BucketAutoOperation to match MongoDB behavior.

MongoDB's $bucket operation always generates _id field with bucket boundaries,
but BucketOperation.getFields() only exposed output fields like 'count'.
This caused IllegalArgumentException when subsequent operations referenced _id.

  • Modified BucketOperationSupport.asExposedFields() to always expose _id
  • Removed defensive fallback in ProjectionOperation that masked the issue
  • Updated and added comprehensive tests for both scenarios
  • Added integration test proving bucket + addFields now works

Closes #5046

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 19, 2025
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2025
christophstrobl pushed a commit that referenced this pull request Sep 9, 2025
Closes: #5046
Original Pull Request: #5047

Signed-off-by: Amine jaoui <[email protected]>
christophstrobl pushed a commit that referenced this pull request Sep 9, 2025
Closes: #5046
Original Pull Request: #5047

Signed-off-by: Amine jaoui <[email protected]>
@christophstrobl
Copy link
Member

Thank you for your contribution @this-amine. Merged to main development line and back ported to 4.5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BucketOperation doesn't expose _id field, causing IllegalArgumentException in subsequent operations
4 participants