-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove defaulting for UUID and BigInteger/BigDecimal representations #5051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now align with the driver recommendation to not favor a particular representation for UUID or BigInteger/BigDecimal to avoid representation changes caused by upgrades to a newer Spring Data version. We expect an explicit configuration by applications.
4 tasks
887053a
to
79603e1
Compare
mp911de
commented
Sep 8, 2025
@@ -27,7 +39,24 @@ | |||
import java.time.LocalDate; | |||
import java.time.LocalDateTime; | |||
import java.time.temporal.ChronoUnit; | |||
import java.util.*; | |||
import java.util.ArrayList; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems something is off with your import *
settings (IDEA Class Count to use *
should be 11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, right - not sure when that happened.
Extend configuration options in a way that allows to register different conversion options for numeric values so users can recreate the 4.x default behaviour using String as default while honoring field specific configuration via the targetType attribute of the Field Annotation.
dd30229
to
12129c4
Compare
Extend configuration options in a way that allows to register different conversion options for numeric values so users can recreate the 4.x default behaviour using String as default while honoring field specific configuration via the targetType attribute of the Field Annotation.
Register BigDecimal and BigInteger as simple types to allow explicitly typed writes and register converters in the ConversionService directly to avoid forcing a specific type. Revert BigDecimalRepresentation list change to use only one representation. In a sense, we're aligning with MongoDB's driver behavior that BigDecimal now maps by default to Decimal128, while BigInteger requires explicit configuration.
christophstrobl
pushed a commit
that referenced
this pull request
Sep 9, 2025
Register BigDecimal and BigInteger as simple types to allow explicitly typed writes and register converters in the ConversionService directly to avoid forcing a specific type. Revert BigDecimalRepresentation list change to use only one representation. In a sense, we're aligning with MongoDB's driver behavior that BigDecimal now maps by default to Decimal128, while BigInteger requires explicit configuration. Original Pull Request: #5051
christophstrobl
added a commit
that referenced
this pull request
Sep 9, 2025
Original Pull Request: #5051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now align with the driver recommendation to not favor a particular representation for UUID or BigInteger/BigDecimal to avoid representation changes caused by upgrades to a newer Spring Data version.
We expect an explicit configuration by applications.
Closes #5037