Vector search on repository level #3037
Conversation
meistermeier
force-pushed
the
issue/gh-3002
branch
from
ec86ddb to
8586fb2
Compare
| @@ -98,11 +101,30 @@ boolean isGeoNearQuery() { | |||
| return GeoPage.class.isAssignableFrom(returnType); | |||
| } | |||
|
|
|||
| boolean isVectorSearchQuery() { | |||
| var repositoryMethod = this.queryMethod.getMethod(); | |||
There was a problem hiding this comment.
Could QueryMethod.isSearchQuery() be useful here?
Would it also make sense to check for the presence of the @VectorSearch annotation?
| @@ -73,10 +75,21 @@ public final class QueryFragmentsAndParameters { | |||
| @Nullable | |||
| private NodeDescription<?> nodeDescription; | |||
|
|
|||
| public QueryFragmentsAndParameters(@Nullable NodeDescription<?> nodeDescription, QueryFragments queryFragments, | |||
There was a problem hiding this comment.
Design-wise, using a builder could help to avoid introducing additional constructors for such a class when extending arguments. That's a learning from various other Spring Data modules that can make your changes less painful.
| @@ -57,6 +57,10 @@ private ReactivePartTreeNeo4jQuery(ReactiveNeo4jOperations neo4jOperations, Neo4 | |||
|
|
|||
| static RepositoryQuery create(ReactiveNeo4jOperations neo4jOperations, Neo4jMappingContext mappingContext, | |||
| Neo4jQueryMethod queryMethod, ProjectionFactory factory) { | |||
| if (queryMethod.hasVectorSearchAnnotation() | |||
| && queryMethod.getVectorSearchAnnotation().get().numberOfNodes() < 1) { | |||
| throw new IllegalArgumentException("Number of nodes in a vector search has to be greater than zero."); | |||
There was a problem hiding this comment.
Nit: It makes sense to check how these exceptions translate during runtime and whether an enclosing exception provides sufficient context to identify the query method that has caused this verification error.
| * | ||
| * @author Gerrit Meier | ||
| */ | ||
| @Retention(RetentionPolicy.RUNTIME) |
There was a problem hiding this comment.
Nit: A bit of Javadoc helps with dev experience, also, @since tags for feature discoverability.
| * @param numberOfNodes number of nodes to fetch from the index search | ||
| * @param score score filter | ||
| */ | ||
| record VectorSearchFragment(String indexName, int numberOfNodes, @Nullable Double score) { |
There was a problem hiding this comment.
Package-protected records FTW. We use these in a similar manner.
Nerd sniping: OptionalDouble 😵💫
| protected static Neo4jExtension.Neo4jConnectionSupport neo4jConnectionSupport; | ||
|
|
||
| @BeforeEach | ||
| void setupData(@Autowired BookmarkCapture bookmarkCapture, @Autowired Driver driver) { |
There was a problem hiding this comment.
Another nerd-snipe: Inject a Session that gets closed after the test run to reduce try repetition.
Signed-off-by: Gerrit Meier <[email protected]>
Signed-off-by: Gerrit Meier <[email protected]> Closes #3002
meistermeier
force-pushed
the
issue/gh-3002
branch
from
baab1c7 to
d1b7692
Compare
|
Closed with merge of d1b7692 |
This will introduce the support for Neo4j vector search.
For now it's focused on the repository level to enhance the derived finder methods.