Add warnings for invalid setter values in ExponentialBackoffPolicy

[kssumin]

This PR addresses #352 by adding warning logs when invalid values are provided to ExponentialBackoffPolicy setters.

Changes

• Added warning logs in setInitialInterval() when value < 1
• Added warning logs in setMultiplier() when value <= 1.0
• Added warning logs in setMaxInterval() when value <= 0

Motivation

The current implementation silently adjusts invalid values without informing users. This can lead to confusion when configured values differ from actual behavior. Adding warning logs helps users understand when their configuration needs adjustment.

Backward Compatibility

This change maintains backward compatibility by:

• Keeping the existing behavior of silently adjusting invalid values
• Only adding warning logs to inform users
• No breaking changes to the API

Related Issue

Closes #352

[artembilan]

Hi @kssumin !

We have release this Friday.
Would be great if this can make it.
If I don't hear from you by then, I'll do some clean up myself on your PR.
Merge it and then follow up commit with what I think is expected from the code.
Thanks

[artembilan]

Error:  Failed to execute goal io.spring.javaformat:spring-javaformat-maven-plugin:0.0.43:validate (default) on project spring-retry: Formatting violations found in the following files:
Error:   * /home/runner/work/spring-retry/spring-retry/src/main/java/org/springframework/retry/backoff/ExponentialBackOffPolicy.java
Error:   * /home/runner/work/spring-retry/spring-retry/src/test/java/org/springframework/retry/backoff/ExponentialBackOffPolicyTests.java
Error:  
Error:  Run `spring-javaformat:apply` to fix.

[kssumin]

@artembilan Thank you for the detailed review! I've addressed all your feedback:

1. Removed the setLogger() method as it shouldn't be exposed to end-users
2. Updated all test methods to use DirectFieldAccessor for reflection-based logger access
3. Simplified all warning messages to avoid redundancy:
   • Initial interval: "Initial interval must be at least 1, but was X"
   • Multiplier: "Multiplier must be > 1.0 for effective exponential backoff, but was X"
   • Max interval: "Max interval must be positive, but was X"
4. Applied spring-javaformat to fix formatting violations

All changes have been implemented in the latest commit. Please let me know if there's anything else that needs to be adjusted.

[artembilan]

Looks good!
Please, add your name to the @author list of the effected classes.

[artembilan]

Error:   * /home/runner/work/spring-retry/spring-retry/src/test/java/org/springframework/retry/backoff/ExponentialBackOffPolicyTests.java
Error:  
Error:  Run `spring-javaformat:apply` to fix.

Please, ensure to run mvnw verify before pushing to the PR.
Thanks

[kssumin]

@artembilan
Thank you for the review! I've run spring-javaformat:apply and completed the verification. The build was successful as shown in the screenshot. This is my first time contributing to open source, so I wasn't familiar with these formatting rules. I appreciate your guidance! I'll make sure to run 'mvnw verify' before pushing to PRs in the future. 😊

[artembilan]

Last remark.
I see this in the commit:

Signed-off-by: kssumin <[email protected]>

That has to be your real legal name.
We cannot accept contributions with nick names.
Also, see if that is real email.

The DCO requirements must be met.

You have to fix your Git client to use your proper legal name.
Then you would need to force-push into this PR with new Signed-off-by.

Thank you for understanding!

[kssumin]

The email was indeed valid, but I've now changed it to a more commonly used email address.
Thank you for explaining these requirements in detail. I appreciate your guidance and have learned a lot from this process.

[artembilan]

Cool! Will merge tomorrow , my morning.
Thank you again!