only use specified listeners in @Retryable
#493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#485 Signed-off-by: Jiandong Ma <[email protected]>
|
您好，我已经收到您的邮件，将尽快给您回复。
|
|
ok，亲~~~
|
|
@artembilan kindly review and suggest. |
artembilan
requested changes
Jun 24, 2025
There was a problem hiding this comment.
@mjd507 ,
thank you for contribution, but we cannot accept it at the moment as we follow no breaking change in the point version.
| public service() { | ||
| // ... do something | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Starting with version 2.0.13, any bean instance of `RetryListener` are not considered as global listeners. | ||
| You always have to explicitly specify the `listeners` attribute in `@Retryable` if needed. |
There was a problem hiding this comment.
And this is exactly why it has not been fixed yet.
This is a breaking change which we don't do according to our backward compatibility support.
This makes sense for a major version and we are not there yet.
We can keep your PR for time being though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #485