TE-4189: Fixed EventTransfer with additional params #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsanmx
reviewed
Apr 11, 2022
src/Spryker/Zed/EventBehavior/Business/Model/EventResourceQueryContainerPluginIterator.php
Show resolved
Hide resolved
src/Spryker/Zed/EventBehavior/Business/Model/EventResourceQueryContainerManager.php
Outdated
Show resolved
Hide resolved
src/Spryker/Zed/EventBehavior/Business/Model/EventResourceQueryContainerManager.php
Show resolved
Hide resolved
vol4onok
commented
Apr 19, 2022
| * | ||
| * @return array<\Spryker\Shared\Kernel\Transfer\AbstractTransfer> | ||
| */ | ||
| public function getData(int $offset, int $limit): array; |
Contributor
Author
There was a problem hiding this comment.
here needs to adjust new interface. will be better to have the transfer here @ehsanmx
dereuromark
reviewed
Jun 22, 2022
| * @param array<int> $ids | ||
| * | ||
| * @return \Iterator<array<\Generated\Shared\Transfer\EventEntityTransfer>> | ||
| * @return \Iterator<array<\Spryker\Shared\Kernel\Transfer\AbstractEntityTransfer>> |
Contributor
There was a problem hiding this comment.
Is this true? isnt the actual object still the concrete one?
dereuromark
reviewed
Jun 22, 2022
|
|
||
| /** | ||
| * @param \Spryker\Zed\EventBehavior\Dependency\Plugin\EventResourcePluginInterface $plugin | ||
| * @param array<\Spryker\Shared\Kernel\Transfer\AbstractTransfer> $transfers |
Contributor
There was a problem hiding this comment.
Those are never "Just" the abstract one - at least those are usually invalid to be used for methods that do not exist
Are you only using methods from the abstract one here?
Contributor
|
@vol4onok is this one still relevant? |
Contributor
Author
|
I don't remember. Needs to re-check. I think it's relevant. But the code is partially outdated @stereomon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @vol4onok
Ticket: https://spryker.atlassian.net/browse/TE-4189
Release Group: https://release.spryker.com/release-groups/view/4054
PR Overview: https://release.spryker.com/release/pull-request-core/EventBehavior/77
merge: squash
Release Table
Module EventBehavior
Change log
Improvements
EventResourceQueryContainerManagerso it's collect all required data toEventEntityTransferinstead of id.EventResourceQueryContainerPluginIteratorso iterator can use ids for build query.