Skip to content

CC-16694: Adjusted EventBehaviorFacade::executeResolvedPluginsBySources() to execute plugins which contain the same resource name #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maritechpro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CC-16694: Adjusted EventBehaviorFacade::executeResolvedPluginsBySources() to execute plugins which contain the same resource name #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions src/Spryker/Zed/EventBehavior/Business/Model/EventResourcePluginResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,38 +199,20 @@ protected function filterPluginsByResources(array $eventResourcePlugins, array $
protected function extractEffectivePlugins($effectivePlugins, $pluginsPerExporter): array
{
foreach ($effectivePlugins as $effectiveEventPlugins) {
$effectivePlugin = $this->findEffectivePlugin($effectiveEventPlugins);

if ($effectivePlugin === null) {
continue;
}

if ($this->isEventResourceRepositoryPlugin($effectivePlugin)) {
$pluginsPerExporter[static::REPOSITORY_EVENT_RESOURCE_PLUGINS][] = $effectivePlugin;
}

if ($this->isEventResourceQueryContainerPlugin($effectivePlugin)) {
$pluginsPerExporter[static::QUERY_CONTAINER_EVENT_RESOURCE_PLUGINS][] = $effectivePlugin;
foreach ($effectiveEventPlugins as $effectiveEventPlugin) {
if ($this->isEventResourceRepositoryPlugin($effectiveEventPlugin)) {
$pluginsPerExporter[static::REPOSITORY_EVENT_RESOURCE_PLUGINS][] = $effectiveEventPlugin;
}

if ($this->isEventResourceQueryContainerPlugin($effectiveEventPlugin)) {
$pluginsPerExporter[static::QUERY_CONTAINER_EVENT_RESOURCE_PLUGINS][] = $effectiveEventPlugin;
}
}
}

return $pluginsPerExporter;
}

/**
* @param array<\Spryker\Zed\EventBehavior\Dependency\Plugin\EventResourcePluginInterface> $eventResourcePlugins
*
* @return \Spryker\Zed\EventBehavior\Dependency\Plugin\EventResourcePluginInterface|null
*/
protected function findEffectivePlugin(array $eventResourcePlugins): ?EventResourcePluginInterface
{
if ($eventResourcePlugins === []) {
return null;
}

return current($eventResourcePlugins);
}

/**
* @param \Spryker\Zed\EventBehavior\Dependency\Plugin\EventResourcePluginInterface $eventResourcePlugin
*
Expand Down