Shell navbar menu extension #430
Conversation
When menu items are specified as objects, "icon" property will be used to add an icon to the left (or instead) of menu title with standard spacing between the icon and title if both are defined.
If "button" attribute is set to True on top-level menu item, format it as a single "button". Supported attributes are copied from the "button" component. Otherwise, preserve previous behavior. Icon can still be added independently, if defined.
If "button" attribute is set to True on submenu item, format it as a single "button". Supported attributes are copied from the "button" component. Otherwise, preserve previous behavior. Icon can still be added independently, if defined. Define "compact"=True on submenu, to remove extra spaing on the right and make sure that icon-only button are stacked (placed one per line).
|
I have updated this pull request to include all changes made in "Parse JSON menu_item for SQLite and skip blank items", so that this pull request could be merged without conflicts after the other one is accepted. Please take a look at the extended "shell" component and accept the pull request, if you think it is OK, or let me know of any issues. |
If "fixed_top_menu" boolean is set to True on the "shell" component, the top navigation bar will be fixed at top. However, it spans the entire page width (probably, by design) regardless of layout used and works best with the fluid layout.
… into shell-navbar-menu
|
I have resolved current conflicts. |
|
Thanks for the PR ! There are multiple things here. I'm still not convinced by the looks of this
But I clearly see the interest of Can you open distinct pull requests ? This will make it easier to merge what can be merged now, and to discuss what still needs to be discussed. |
|
To clarify, the three new PRs are just that (parts of this PR). |
|
Great, I already merged the sticky top menus. I'm closing this one in favor of the others, then |
This modified "shell" component extends menu functionality (primarily adds support for icons in menu items and styling menu items as buttons). This pull request also contains a sample hybrid menu demo file menu_demo.sql.