mysql: make pub: MySqlValueRef::format/as_bytes/as_str() #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovasoa
approved these changes
Jun 23, 2025
|
No problem, happy to make these public; Thanks for the pr! |
|
Just to understand your usage better: what do you need these methods for ? Do we have some |
|
@lovasoa https://github.com/kakserpom/php-sqlx-rs/blob/master/src/mysql/conversion.rs#L73: SIMD json decoding and lazy json decoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need these methods to be public (well, actually I only need as_bytes) in order to implement custom JSON deserialization. The Postgres driver already allows to get raw values.