Move AnyAsyncSequenceWorker into WorkflowConcurrency as AsyncSequenceWorker #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjohnson12
force-pushed
the
markj/asyncsequence_worker
branch
from
e7ec195 to
04a8cd0
Compare
mjohnson12
changed the title
mjohnson12
commented
Jun 2, 2025
| guard let output = output as? Output else { | ||
| fatalError("Unexpected output type \(type(of: output)) from worker \(worker)") | ||
| } | ||
| await sendAction(output: output, sink: sink) |
There was a problem hiding this comment.
If I change this to do what the async function worker does to call send on sink by adding:
let send: @MainActor (Output) -> Void = sink.send
It crashes the compiler
There was a problem hiding this comment.
Pushing up a change to just call MainActor run so we don't need the sendAction function just to call sink.send on the main actor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
AnyAsyncSequenceWorkerfromWorkflowExperimentalin register intoWorkflowConcurrencyasAsyncSequenceWorker.Checklist