test(extraction): close missing signature-case gaps, python/js AI/ML pack first - #1079
Merged
Merged
Conversation
…pack first Closes #1072. audit_strict_coverage.py's missing_case_entirely list found 44 non-None LANGUAGE_DEFINITIONS keys with zero _SIMPLE_CASES coverage across 6 languages -- most notably python's and javascript's entire AI/ML extension pack (llm_api, llm_orchestrator, llm_vector_store, ml_traditional, dl_frameworks) had no detection test coverage at all, a real blind spot in a supply-chain-risk detection feature. Every candidate case was empirically verified with verify_candidates.py's check_case against the real compiled regex before being written in; no engine bugs surfaced (expected -- this suite proves presence/absence of a construct, not exact-identifier extraction, per how_to_harden_strict_signatures.md). python: 19 keys, javascript: 16, haskell: 4, objective-c: 3, solidity: 1, yaml: 1. Re-running audit_strict_coverage.py confirms missing_case_entirely is now empty for all six languages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audit_strict_coverage.py'smissing_case_entirelylist).LANGUAGE_DEFINITIONSkeys across 6 languages had zero_SIMPLE_CASEScoverage in theirtest_<lang>_strict.pyfiles. Most notably, python's and javascript's entire AI/ML extension pack (llm_api,llm_orchestrator,llm_vector_store,ml_traditional,dl_frameworks) had no detection test coverage at all — a real blind spot in a supply-chain-risk detection feature, not just a test-depth nit.verify_candidates.py'scheck_caseagainst the real compiled regex before being added — no engine bugs surfaced (expected perhow_to_harden_strict_signatures.md: this suite proves presence/absence of a construct, not exact-identifier extraction, so it's almost entirely test-writing, not regex-fixing).Test plan
pytest tests/extraction/languages/test_{python,javascript,haskell,objectivec,solidity,yaml}_strict.py— 330 passedpytest tests/extraction/(full suite) — 4852 passed, 2 skipped, 10 xfailed, 3 xpassedpython tests/tools/audit_check.py— clean, no new ruff/mypy/dead-key findingspython tests/extraction/tools/audit_strict_coverage.py --lang <x> --jsonre-run for all 6 languages —missing_case_entirely: []for each🤖 Generated with Claude Code