Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix godoc links at top of README #34

Merged
merged 1 commit into from
May 3, 2018
Merged

Fix godoc links at top of README #34

merged 1 commit into from
May 3, 2018

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented May 3, 2018

They were pointing at v1 whereas the rest of the doc points at v2.

@vmarkovtsev
Copy link
Collaborator

Thanks!

Could you please add the signed-off-by (DCO check).

@dsymonds
Copy link
Contributor Author

dsymonds commented May 3, 2018 via email

@vmarkovtsev
Copy link
Collaborator

Thanks again. This is OK from the legal point of view and I can merge this right now, but let me ask first if it is possible to execute

git commit --amend --no-edit --signoff
git push -f origin patch-1

I see that you used the GitHub web UI to create the fix, so I guess it will be a pain. At the same time, when we will do license audit in the future, we will see that all the external contributions are signed-off without having to go to this specific PR page.

They were pointing at v1 whereas the rest of the doc points at v2.

Signed-off-by: David Symonds <[email protected]>
@dsymonds
Copy link
Contributor Author

dsymonds commented May 3, 2018

Yeah, understand. A bit annoying, but done.

@vmarkovtsev vmarkovtsev merged commit 85f083f into src-d:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants