Expose analyse results to api #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So clients can benefit from a rich data structure that contains results for one or more project paths and that can be parsed as JSON. The json data structure was already available in the main.go, so I merely moved it to a top level go file to make it easier to expose. Signed-off-by: Sebastien Bonnet <[email protected]>
Use the correct golint import path. This was recently changed to only affect import paths for go 1.12+ which explains why the build previously failed on `tip` See golang/lint@c67002c Signed-off-by: Sebastien Bonnet <[email protected]>
Signed-off-by: Sebastien Bonnet <[email protected]>
Signed-off-by: Sebastien Bonnet <[email protected]>
As it carries the same information as ErrStr and was used only internally to check for detection errors in main.go Signed-off-by: Sebastien Bonnet <[email protected]>
Signed-off-by: Sebastien Bonnet <[email protected]>
Signed-off-by: Sebastien Bonnet <[email protected]>
sebbonnet
force-pushed
the
expose-analyse-results-to-api
branch
from
e03d9c2 to
7bf9130
Compare
|
@vmarkovtsev @campoy I mistakenly closed the initial PR #42, so here is the new one. |
sebbonnet
commented
Nov 27, 2018
| ) | ||
|
|
||
| func TestMain(t *testing.T) { | ||
| func TestCmdMain(t *testing.T) { |
There was a problem hiding this comment.
Changed the method name to avoid clashing with https://golang.org/pkg/testing/#hdr-Main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So clients can benefit from a rich data structure that contains licence detection results
for one or more project paths and that can be parsed as JSON.
The json data structure was already available in main.go,
so I merely moved it to a top level go file to make it easier to expose.
Signed-off-by: Sebastien Bonnet [email protected]`