Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file matches to detection result #56

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented Aug 14, 2019

This adds file matches to the detection result, changing the API as minimally as possible from map[string]float32 to map[string]api.Match where api.Match is

type Match struct {
    Confidence float32
    Files map[string]float32
}

I had to add an api package in order not to have any conversions or cyclic dependencies between the internal and licensedb package.

Fixes #55

Copy link
Collaborator

@vmarkovtsev vmarkovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this PR is so awesome, thank you very much for such polished code!

A few import formats and we are done.

@adracus adracus force-pushed the feature.file-matches branch from 87b8a6f to 79f5d7c Compare August 19, 2019 18:01
@adracus
Copy link
Contributor Author

adracus commented Aug 19, 2019

Hi, thanks for the feedback! I've addressed your comments, hope that's okay!

@vmarkovtsev vmarkovtsev merged commit 0ba3cd1 into src-d:master Aug 19, 2019
@vmarkovtsev
Copy link
Collaborator

I will release v3 tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return matching license files
2 participants