Fix make #61
Merged
Fix make #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tevin Zhang <[email protected]>
tevino
force-pushed
the
fix-make
branch
2 times, most recently
from
b7f2a44 to
926b44e
Compare
vmarkovtsev
requested changes
Sep 11, 2019
vmarkovtsev
requested changes
Sep 11, 2019
tevino
force-pushed
the
fix-make
branch
2 times, most recently
from
9a4ebb6 to
f231591
Compare
Signed-off-by: Tevin Zhang <[email protected]>
Signed-off-by: Tevin Zhang <[email protected]>
As of 2019-09-12 the newest tag of github.com/jteeuwen/go-bindata is v3.0.7 which is not the latest that supports -nometadata as used in Makefile. The correct version (instead of v3.0.7) of go-bindata will be downloaded by `go get` after this modification. Signed-off-by: Tevin Zhang <[email protected]>
vmarkovtsev
approved these changes
Sep 12, 2019
|
Interesting 1.13 build passed, but 1.11 and 1.12 did not: they do not like the absence of go.mod in jteeuwen/go-bindata |
Indeed, I haven't figure out a good way to install the latest Do you have any idea? |
To keep `go get` from complaining prior to go 1.13: missing github.com/jteeuwen/go-bindata/.../go.mod at revision 6025e8de665b Signed-off-by: Tevin Zhang <[email protected]>
Signed-off-by: Tevin Zhang <[email protected]>
|
Works now! |
|
Thank you. I will make a new release in a few hours. |
|
v3 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60
Should I add the above link into the commit message?