Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source_ref to point to default branch #39

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Flo0807
Copy link
Contributor

@Flo0807 Flo0807 commented Feb 8, 2025

Hey there!

You don't seem to be using git tags, but your source_ref is set to a specific version. This results in 404 pages when trying to view the source from your docs:

CleanShot 2025-02-08 at 16 24 24

This merge request sets source_ref to master (default branch). This way you will be redirected to a valid GitHub page when you try to view the source.

The downside is that you will always be redirected to the latest version of the package (master branch), even if you are on an older docs page, but I guess it is better than being redirected to 404 pages.

@srcrip
Copy link
Owner

srcrip commented Feb 14, 2025

Very nice, didn't even notice that! Thanks @Flo0807!

@srcrip srcrip merged commit 5d56f7b into srcrip:master Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants