馃悰 fix : speed not updating in UI fixed - #128
Open
STRO09 wants to merge 1 commit into
Open
Conversation
|
@STRO09 is attempting to deploy a commit to the Samuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Speed change was not being reflected in UI Topbar upon acceleration. that has been fixed.
the onHud prop / function passed to cityCanvas to update the properties like the current speed and the positions were not getting passed the correct values in VehicleFlight. Instead of the current speed, the base speed was being passed, so now actualSpeed has been passed. And for pause, 0 was passed explicitly. so its now working for four different speeds, base Speed 55, accerelated speed, slow down speed, flymode stopped speed (zero).
Fixes #125
Screenshots
Checklist
npm run lintpasses