Prevent inflight array index crash and precondition failure on password buffer #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
func failEntries - there was an index out of bounds, cause the array was modified (remove(at:)) during enumeration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes two independent but related fixes:
Fix index out-of-range crash in
MQTTRequestHandler.channelReadentriesInflightduring iteration with acompactMapto safely remove completed entries without corrupting indices.Fix potential
preconditionFailurewhen writing CONNECT packet passwordpasswordbuffer has a valid reader index and is not empty before passing towriteMQTTDataWithLengthThank you.
Tobias