Фикс использования hand labeler на ящиках#9346
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the SIGNAL_HANDLER macro to the OnAttackby and Examine procs of the label component, and introduces interaction logic for the hand labeler on closets. The reviewer identified an issue where unconditionally returning ATTACK_CHAIN_PROCEED when using a hand labeler on a closet breaks standard open/close interactions when the labeler is turned off, and provided a detailed recommendation to fix this logic.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if(GetComponent(/datum/component/label)) | ||
| add_fingerprint(user) | ||
| SEND_SIGNAL(src, COMSIG_ATOM_ATTACKBY, labeler, user, params) | ||
| return ATTACK_CHAIN_BLOCKED_ALL |
| if(GetComponent(/datum/component/label)) | ||
| add_fingerprint(user) | ||
| SEND_SIGNAL(src, COMSIG_ATOM_ATTACKBY, labeler, user, params) | ||
| return ATTACK_CHAIN_BLOCKED_ALL |
There was a problem hiding this comment.
Это реально костыль какой-то, на ТГ этого компонента не существует, посмотри как у них лейблер работает
3 participants
Что этот ПР делает
https://discord.com/channels/617003227182792704/1511772048819622028
Список изменений
🆑
bugfix: Можно использовать hand labeler на ящиках
/:cl: