Skip to content

Implement slowEqual enhancement from #128 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Barbarrosa
Copy link
Contributor

@Barbarrosa Barbarrosa commented Apr 10, 2021

This PR improves the speed of slowEqual by using bipf.createSeekPath as suggested in #128.

Before

Part Speed Heap Change Samples
Query 1 big index with slowEqual (1st run) 906.45ms ± 16.61ms -851.7 kB ± 41.62 kB 5
Query 1 big index with slowEqual (2nd run) 245.64ms ± 7.76ms -697.62 kB ± 38.45 kB 5
Query 1 big index with slowEqual (3rd run) 0.31ms ± 0.15ms 38.13 kB ± 0 kB 5

After

Part Speed Heap Change Samples
Query 1 big index with slowEqual (1st run) 866.11ms ± 35ms 1.07 MB ± 0 MB 5
Query 1 big index with slowEqual (2nd run) 296.57ms ± 4.96ms 528.21 kB ± 0 kB 5
Query 1 big index with slowEqual (3rd run) 0.27ms ± 0.02ms -85.7 kB ± 0 kB 5

@Barbarrosa
Copy link
Contributor Author

Barbarrosa commented Apr 10, 2021

Edit: I updated the description w/ the benchmark results from the Github job.

Actual change coming in a minute, figured I'd push the benchmark first to have a point of comparison using a similar runtime env.

@arj03
Copy link
Member

arj03 commented Apr 11, 2021

The second run seems slower?

@Barbarrosa
Copy link
Contributor Author

@arj03 I ran this with the parallel benchmark, and those results also don't support using bipf.createSeekPath. I'll close this PR and note this on the original issue.

Before

Part Speed Heap Change Samples
Query 1 big index with slowEqual (1st run) 1227.72ms ± 30.83ms -43.01 kB ± 18.86 kB 45
Query 1 big index with slowEqual (2nd run) 302.25ms ± 1.66ms 77.83 kB ± 0 kB 40
Query 1 big index with slowEqual (3rd run) 0.29ms ± 0.02ms 21.15 kB ± 0 kB 44

After

Part Speed Heap Change Samples
Query 1 big index with slowEqual (1st run) 1407.86ms ± 54.24ms 19.31 kB ± 0 kB 39
Query 1 big index with slowEqual (2nd run) 296.6ms ± 1.45ms 1.95 kB ± 0 kB 45
Query 1 big index with slowEqual (3rd run) 0.36ms ± 0.03ms 3 kB ± 26.53 kB 48

@Barbarrosa Barbarrosa closed this Apr 11, 2021
This was referenced Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants