Add prefixOffset option #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Odd, that test failure is unrelated to this change. |
|
Seems to be a problem in the test runner... |
|
Yeah, seems unrelated. But here's a proposed fix: - state = validate.appendNew(state, null, keys, msg1, Date.now() + 3000)
- state = validate.appendNew(state, null, keys, msg2, Date.now() + 2000)
- state = validate.appendNew(state, null, keys, msg3, Date.now() + 1000)
+ const now = Date.now()
+ state = validate.appendNew(state, null, keys, msg1, now + 3000)
+ state = validate.appendNew(state, null, keys, msg2, now + 2000)
+ state = validate.appendNew(state, null, keys, msg3, now + 1000) |
|
I think the problem is bigger than that. Working on a fix in a different branch |
staltz
requested changes
Jan 25, 2021
Benchmark results
|
|
I'll do a PR against db2 when this is ready for key & others that might have use of this :) |
Benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible specifiy where in the target the prefix buffer should be constructed from.
Some motivation here, it will make some certain prefix indexes much faster.