-
Notifications
You must be signed in to change notification settings - Fork 164
[RORDEV-1472] Run integration tests on Windows with native Windows version of ES #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RORDEV-1472] Run integration tests on Windows with native Windows version of ES #1154
Conversation
# Conflicts: # tests-utils/build.gradle
…ation-tests-on-windows # Conflicts: # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/audit/LocalClusterAuditingToolsSuite.scala
.../scala/tech/beshu/ror/integration/LdapServerDiscoveryCheckYamlLoadedAccessControlTests.scala
Outdated
Show resolved
Hide resolved
.../scala/tech/beshu/ror/integration/LdapServerDiscoveryCheckYamlLoadedAccessControlTests.scala
Outdated
Show resolved
Hide resolved
integration-tests/src/test/scala/tech/beshu/ror/integration/suites/RemoteReindexSuite.scala
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/images/Elasticsearch.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/images/Elasticsearch.scala
Outdated
Show resolved
Hide resolved
...-utils/src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoEsContainer.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoWiremockContainer.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/elasticsearch/BaseManager.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/misc/OsUtils.scala
Outdated
Show resolved
Hide resolved
6d497b7
to
b15528a
Compare
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoContainer.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoContainer.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoContainer.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoWiremockContainer.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/tech/beshu/ror/utils/containers/windows/WindowsPseudoWiremockContainer.scala
Outdated
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/misc/OsUtils.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But to do left:
- The mentioned minor changes
- The docs improvements reminder
- I'm not sure (I don't want to go through the PR again) - did you fix some Windows-related issues in this PR too? If so, it'd be nice to mention them in the changelog description.
|
🐞Fix (ES) Fixed LDAP Common Name (CN) double encoding issue when ES is installed on Windows
Summary by CodeRabbit
New Features
Bug Fixes
Chores
Documentation
Tests