Skip to content

Conversation

mgoworko
Copy link
Collaborator

@mgoworko mgoworko commented Aug 31, 2025

🐞Fix (ES) Fixed LDAP Common Name (CN) double encoding issue when ES is installed on Windows

Summary by CodeRabbit

  • New Features

    • Expanded Windows support across CI and tests: Windows-specific test runs, pseudo-containers, ES-on-Windows helpers and predefined Windows ports.
  • Bug Fixes

    • Updated LDAP test data and sample directories; normalized line endings and regexes for cross-platform consistency.
  • Chores

    • CI gating refined with separate Linux/Windows test actions and updated pipeline parameters; Windows-aware test wiring and ports.
  • Documentation

    • CLI help updated to show default ES path /usr/share/elasticsearch.
  • Tests

    • Added test JSON wrapper, many test imports, OS-aware guards, timing/stability improvements and Windows-specific test adjustments.

@mgoworko mgoworko requested a review from coutoPL September 7, 2025 11:14
…ation-tests-on-windows

# Conflicts:
#	integration-tests/src/test/scala/tech/beshu/ror/integration/suites/audit/LocalClusterAuditingToolsSuite.scala
coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@mgoworko mgoworko force-pushed the RORDEV-1472-integration-tests-on-windows branch from 6d497b7 to b15528a Compare September 23, 2025 19:01
coderabbitai[bot]

This comment was marked as resolved.

@mgoworko mgoworko requested a review from coutoPL September 23, 2025 19:28
coderabbitai[bot]

This comment was marked as resolved.

@mgoworko mgoworko requested a review from coutoPL September 24, 2025 20:39
coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Collaborator

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But to do left:

  1. The mentioned minor changes
  2. The docs improvements reminder
  3. I'm not sure (I don't want to go through the PR again) - did you fix some Windows-related issues in this PR too? If so, it'd be nice to mention them in the changelog description.

@mgoworko
Copy link
Collaborator Author

mgoworko commented Sep 25, 2025

  1. IMPORTANT: I reverted adding synchronized on getPort method. It turned out, that this method is called during container startup, for example during RorStartingSuite tests. I think synchronized is not strictly required in that method (it it a read-only operation in a given moment in time)

  2. oneliner PR in docs [RORDEV-1472] Added notice about regex format on Windows beshu-tech/readonlyrest-docs#282

  3. there is only one thing - fixed double-encoding of LDAP cn (I caused LDAP tests to fail on Windows. I am not sure if it would cause production issues, perhaps it depends on LDAP used. Added to changelog)

@mgoworko mgoworko merged commit 43b9625 into sscarduzio:develop Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants