Add a socket receive buffer #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
commented
Nov 7, 2025
Comment on lines
+1993
to
+1971
| if (_socket is { } s) | ||
| { | ||
| s.ReceiveTimeout = 0; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
this is just moved out from the previous implementation of TrySocketRead
Rob-Hague
force-pushed
the
sessionbuffer
branch
from
46e9dff to
249e2c6
Compare
Currently an array is allocated to read each packet from the socket, followed by decryption which allocates another array for the plaintext payload. We can save one of these two allocations by adding a persistent buffer for socket receives, and allowing the cipher implementations to decrypt into the given payload array. We can save the other allocation similarly, but in a separate change.
Rob-Hague
force-pushed
the
sessionbuffer
branch
from
249e2c6 to
c88348d
Compare
Collaborator
|
@Rob-Hague How does this affect performance? |
WojciechNagorski
approved these changes
Nov 18, 2025
Collaborator
Author
|
I am not expecting any noticeable speed improvements (will check). I will demonstrate the memory improvements in the next PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an array is allocated to read each packet from the socket, followed by decryption which allocates another array for the plaintext payload. We can save one of these two allocations by adding a persistent buffer for socket receives, and allowing the cipher implementations to decrypt into the given payload array.
We can save the other allocation similarly, but in a separate change.