Skip to content

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 7, 2025

The new version of the DID finder library has standard exceptions that are used to signal specific error conditions. This will allow us to fail requests when they make bad requests, see #927 .

@ponyisi ponyisi requested a review from Copilot October 7, 2025 11:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates three DID finder services to use standardized exceptions from the DID finder library instead of generic exceptions. This change will enable proper error handling and allow the system to respond appropriately to different types of failures when processing dataset lookup requests.

Key changes:

  • Replace generic exceptions with specific exception types: BadDatasetNameException, NoSuchDatasetException, and LookupFailureException
  • Update dependency versions to servicex-did-finder-lib = "^3.1.1" to access the new exception types
  • Add proper exception handling with try-catch blocks where needed

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
did_finder_xrootd/src/servicex_did_finder_xrootd/celery.py Replaces RuntimeError with NoSuchDatasetException and adds exception handling for XRootD operations
did_finder_xrootd/pyproject.toml Updates servicex-did-finder-lib dependency to version 3.1.1
did_finder_rucio/src/rucio_did_finder/rucio_adapter.py Replaces generic exceptions and None returns with specific DID finder exceptions
did_finder_rucio/pyproject.toml Updates servicex-did-finder-lib dependency to version 3.1.1
did_finder_cernopendata/src/did_finder_cernopendata/celery.py Replaces generic Exception with specific exceptions and adds error code-based exception handling
did_finder_cernopendata/pyproject.toml Updates servicex-did-finder-lib dependency to version 3.1.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 13 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant