fix: calculate max output tokens based on budget thinking tokens #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipeship
force-pushed
the
hotfix/budget-output-tokens
branch
from
bc85f92 to
0b5200b
Compare
rekram1-node
force-pushed
the
hotfix/budget-output-tokens
branch
from
0b5200b to
2ce4744
Compare
lacymorrow
pushed a commit
to lacymorrow/lash
that referenced
this pull request
Sep 8, 2025
Co-authored-by: rekram1-node <[email protected]>
aemr3
pushed a commit
to aemr3/opencode
that referenced
this pull request
Sep 18, 2025
Co-authored-by: rekram1-node <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a proposal to make the process of enabling reasoning on Anthropic models not a pita.
the current implementation can cause max tokens errors when
budgetTokensis set, forcing users to debug token limits, etc.this change fixes that by adjusting the max output tokens automatically.
closes #2055