Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update spatial function changes in CQL2 #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update spatial function changes in CQL2 #28

wants to merge 2 commits into from

Conversation

philvarner
Copy link
Contributor

@philvarner philvarner commented Apr 3, 2024 •
edited
Loading

Related Issue(s):

Proposed Changes:

  1. Update conformance class names from Operator to Function
  2. add Basic Spatial Functions with additional Spatial Literals class
  3. rename a few other conformance classes

PR Checklist:

  • This PR has no breaking changes. BREAKING CHANGES
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as ready for review April 3, 2024 22:12
@philvarner philvarner requested a review from matthewhanson April 3, 2024 22:12
@gadomski gadomski self-requested a review April 4, 2024 15:18
gadomski
gadomski reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but leaving official approval to @matthewhanson

pjhartzell
pjhartzell reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments outside of the changes:

  1. L169 of the README: - Item Search Filter (https://api.stacspec.org/v1.0.0-rc.3/item-search#filter) binds the Filter and...

Update the stacspec.org link to v1.0.0?

  1. L251 of the README: These projects have or are developing CQL2 support:

List stac-server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski left review comments

@pjhartzell pjhartzell pjhartzell left review comments

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philvarner @gadomski @pjhartzell