Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to clients #239

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Add names to clients #239

merged 4 commits into from
Nov 5, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Nov 4, 2024

Related issues and pull requests

Description

Bit a YOLO implementation, but I tested locally by forcing s3:

$ stac-asset download --client s3 tests/data/item.json 2>&1 | grep s3_client -A 1
  File "/Users/gadomski/Code/stac-utils/stac-asset/src/stac_asset/s3_client.py", line 113, in open_url
    response = await client.get_object(**self._params(url))

Checklist

  • Add tests
  • Add docs
  • Update CHANGELOG

@gadomski gadomski requested a review from ircwaves November 4, 2024 19:44
@gadomski gadomski self-assigned this Nov 4, 2024
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two suggestions bring the dynamism I like, that is maybe unnecessary.

src/stac_asset/client.py Outdated Show resolved Hide resolved
src/stac_asset/_cli.py Outdated Show resolved Hide resolved
@gadomski
Copy link
Member Author

gadomski commented Nov 5, 2024

Brought in a bit of a hotter spice 🌶️ thanks for the review!

@gadomski gadomski enabled auto-merge (squash) November 5, 2024 20:59
@gadomski gadomski merged commit c164de2 into main Nov 5, 2024
9 of 10 checks passed
@gadomski gadomski deleted the issues/93-clients-set-names branch November 5, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli needs a method to specify a client Each client should set its own name
2 participants