Support forwarded headers that do not contain a host key #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
The proxy header middleware doesn't parse the value of the
protokey in case there is nohostkey as well. Which is the case ifstac-fastapiis running on GCP as cloud run service behind their load balancer. Additionally it even failed withUnboundLocalErrorsinceport_strwas never defined in that execution path but still used later on.That's a small oversight from the last PR (#782) - I noticed it now after upgrading to v4.0.
I also added a testcase for an exact
forwardedheader that I receive on gcp - so that hopefully this finally fixes the issue.PR Checklist:
pre-commithooks pass locallymake test)make docs)