Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datetime titles #19

Closed
wants to merge 1 commit into from
Closed

Update datetime titles #19

wants to merge 1 commit into from

Conversation

zakjan
Copy link

@zakjan zakjan commented Sep 13, 2022

The spec for datetime field mentions that it can be a representative datetime instead of an acquisition datetime.

I suggest to update datetime field titles from "Acquired" to a simple neutral "Datetime", because it can contain any representative datetime depending on the data.

For example, there is a new forecast extension being drafted which is going to use a forecast datetime in datetime field. See stac-extensions/forecast#1 and stac-extensions/forecast#7 for the related discussion.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@m-mohr
Copy link
Contributor

m-mohr commented Sep 14, 2022

Yeah, this is true and should be changed.

I may even go one step further and give different titles depending on the implemented extensions.

@zakjan
Copy link
Author

zakjan commented Sep 14, 2022

different titles depending on the implemented extensions

Yes, makes perfect sense. It might require changes in the API, I haven't explored it further yet. For now I just corrected the default title.

@m-mohr
Copy link
Contributor

m-mohr commented Sep 14, 2022

Ah, haha, I didn't realize this is a PR, thought it's only an issue.

I don't like "Datetime" a lot because it's a bit "technical", basically just the property name with an uppercase D ;-) I'm looking for something that a "non-technical" person would write. Maybe just "Date" or "Date and time" or so... Thoughts?

@zakjan
Copy link
Author

zakjan commented Sep 14, 2022

It's true, but other field titles are created similarly... created -> Created etc.

@m-mohr
Copy link
Contributor

m-mohr commented Sep 14, 2022

Yeah, although Created can be found in a dictionary, Datetime can't (I think). But yeah, "Creation Time" could be a longer version of it if we want. But then "Modified" would be "Modification time" (?) which feels a bit long.

@m-mohr
Copy link
Contributor

m-mohr commented Jan 11, 2023

Fixed in the meanwhile, I think.

@m-mohr m-mohr closed this Jan 11, 2023
@zakjan
Copy link
Author

zakjan commented Jan 12, 2023

Thanks! I was only concerned about the specific Acquired, I don't mind any other wording if it's generic enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants