-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out mypy #44
Break out mypy #44
Conversation
|
||
- name: Type check | ||
run: mypy . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still quite confused by hatch. This will use the hatch env? Even without running something like hatch run mypy .
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm I don't use any hatch
commands directly locally. My shell automatically activates the virtulaenv when I cd
into the directory.
In the case of the GHA, I don't think there's a virtulenv at all. Just running stuff in some python interpreter.
I think our only hard requirement on using hatch is at build time (and even that is hidden by python -m build .
, which figures out how to use hatch for building the wheel and sdit based on the metadata in pyproject.toml).
But in general: we need a contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I'm a big fan of Poetry and Pixi but have never used hatch before, so I'm learning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, in that there's (ideally) nothing new to learn if you don't want to :)
Moves mypy out of pre-commit and into a separate CI check.