Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated tests #20

Closed
4 tasks done
Tracked by #169
l0b0 opened this issue Nov 17, 2021 · 8 comments · Fixed by #40
Closed
4 tasks done
Tracked by #169

Add automated tests #20

l0b0 opened this issue Nov 17, 2021 · 8 comments · Fixed by #40
Assignees
@l0b0 @m-mohr

Comments

@l0b0
Copy link
Collaborator

l0b0 commented Nov 17, 2021 •
edited
Loading

As per @m-mohr, it would be good to get some automated tests to verify that things like Dependabot PRs don't break anything.

Suggestions:

  • Verify the output and exit code of running stac-node-validator without any parameters.
  • Verify the output and exit code when validating some valid, trivial JSON+schema.
  • Verify the output and exit code when validating some invalid, trivial JSON+valid schema.
  • Verify the output and exit code when validating some valid, trivial JSON+invalid schema.
  • Maybe add --help / --version flags?

Any other suggestions @m-mohr?
This was referenced Nov 17, 2021
Closed
Merged
@m-mohr
Copy link
Collaborator

m-mohr commented Nov 19, 2021

Sounds good to me, thanks.

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 29, 2021

So basic tests are in, but Windows is not working yet...

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 29, 2021 •
edited
Loading

ospec doesn't work on Windows - see MithrilJS/ospec#35 - and unfortunately the PR is open since a year.
That's unfortunate as I'm on Windows and would like to run and work on tests. So should we migrate to jest?

@l0b0
Copy link
Collaborator Author

l0b0 commented Nov 29, 2021

Can do; I guess it shouldn't take long…

@l0b0
Copy link
Collaborator Author

l0b0 commented Nov 29, 2021

I've got a couple other PRs for you in the meantime.

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 29, 2021

Already on it :-) Thanks.

@m-mohr
Copy link
Collaborator

m-mohr commented Nov 29, 2021

Give me a couple of minutes.

@l0b0 l0b0 mentioned this issue Nov 29, 2021
Closed
@m-mohr
Copy link
Collaborator

m-mohr commented Nov 29, 2021

Has been migrated to jest, sorry that we seem to have worked on the same thing.
Also added a "successful" test.

This was referenced Dec 5, 2021
Closed
Closed
m-mohr added a commit that referenced this issue Dec 7, 2021
@m-mohr
Test for validating an invalid catalog #20
f928599
@l0b0 l0b0 mentioned this issue Dec 8, 2021
Merged
l0b0 referenced this issue in linz/stac-node-validator Dec 8, 2021
@m-mohr @l0b0
Test for validating an invalid catalog #20
982a857
@m-mohr m-mohr closed this as completed in #40 Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l0b0 l0b0

@m-mohr m-mohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Verify invalid schema handling linz/stac-node-validator
2 participants
@l0b0 @m-mohr