-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI tests #22
Add CLI tests #22
Conversation
dbddc6c
to
ecd5a75
Compare
Thanks a lot. Just want to let you know I've got this on the radar as I may not get to review it in the next 2 weeks due to traveling. |
OK, I just need some feedback on the general approach before adding more tests. |
Yes, the direction is good, thanks. ospec works for me although I've never worked with it before. Until we have a non-CLI return mode, we'd probably also need to check the content of the CLI validation output a bit better, but not sure how that works with ospec. Please clarify or remove the additional files that seem unrelated to the tests. |
c036f49
to
4a4e029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We could try to run a wider variety of OS instead of so many versions of a single OS.
Do you plan to add more tests in this PR or is it ready for now?
Adds a lightweight testing framework, ospec.
Runs on all non-deprecated GitHub runners for maximum portability guarantees.
I do want to add more tests later, but this gets us started. I'd say it's ready now, although I think you have to enable GitHub Actions on this repo to actually run them. I've not tested on Windows or Mac. |
I can't enable anything, maybe I just need to merge |
Seems like Windows is failing, so still some work ahead :) I can look into the Windows issues in the next days |
* tests: Verify exit code when running without parameters Adds a lightweight testing framework, ospec. * feat: Add GitHub Actions pipeline with test job Runs on all non-deprecated GitHub runners for maximum portability guarantees. * docs: Explain how to test and how to disable testing * tests: Verify error message when running without parameters
@m-mohr How is this approach?
Contributes towards #20.