Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use AnyUrl for comparisons #163

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: use AnyUrl for comparisons #163

merged 1 commit into from
Jan 8, 2025

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jan 7, 2025

This worked as-was in pydantic v2.9 but not in v2.10. I discovered b/c tests were broken in main with pydantic v2.10.4:

$ uv pip install pydantic==2.10.4 
Resolved 4 packages in 9ms
Uninstalled 2 packages in 7ms
Installed 2 packages in 3ms
 - pydantic==2.9.2
 + pydantic==2.10.4
 - pydantic-core==2.23.4
 + pydantic-core==2.27.2
$ pytest -q
-- >8 ---
FAILED tests/api/test_landing_page.py::test_landing_page_invalid_features[landing_page_core.json] - Failed: DID NOT RAISE <class 'pydantic_core._pydantic_core.ValidationError'>
FAILED tests/api/test_landing_page.py::test_landing_page_invalid_features[landing_page_ogcapi-features.json] - Failed: DID NOT RAISE <class 'pydantic_core._pydantic_core.ValidationError'>

This worked as-was in pydantic v2.9 but not in v2.10
@gadomski gadomski requested a review from vincentsarago January 7, 2025 22:54
@gadomski gadomski self-assigned this Jan 7, 2025
@vincentsarago vincentsarago merged commit a2a7b1a into main Jan 8, 2025
5 checks passed
@vincentsarago vincentsarago deleted the fix-tests branch January 8, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants